Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename crate features #561

Merged
merged 1 commit into from
Nov 19, 2022
Merged

rename crate features #561

merged 1 commit into from
Nov 19, 2022

Conversation

phip1611
Copy link
Contributor

This implements the ideas of #560 .

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 self-assigned this Nov 12, 2022
@phip1611 phip1611 mentioned this pull request Nov 12, 2022
Closed
@phip1611 phip1611 linked an issue Nov 12, 2022 that may be closed by this pull request
Discuss Crate Features #560
Closed
@phip1611 phip1611 force-pushed the feature-rename branch 4 times, most recently from b0a2ed2 to 257c447 Compare November 12, 2022 15:27
@phip1611 phip1611 marked this pull request as ready for review November 12, 2022 15:30
@phip1611 phip1611 force-pushed the feature-rename branch 3 times, most recently from a29afbd to fd62a73 Compare November 12, 2022 15:58
GabrielMajeri
GabrielMajeri reviewed Nov 13, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
book/src/how_to/crate_features.md Outdated Show resolved Hide resolved
uefi-services/Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@phip1611 phip1611 mentioned this pull request Nov 14, 2022
Open
@phip1611
Copy link
Contributor Author

I updated the PR to match the latest main branch.

@phip1611 @nicholasbishop
rename crate features
bb5fcc3 
To prevent confusion, this renames the `alloc` crate feature to
`global_allocator` and the `exts` feature to `alloc` to match the
conventions of the ecosystem.
@nicholasbishop nicholasbishop merged commit 76b5a22 into rust-osdev:main Nov 19, 2022
@phip1611 phip1611 deleted the feature-rename branch November 19, 2022 17:40
@phip1611
Copy link
Contributor Author

phip1611 commented Nov 19, 2022 •
edited
Loading

Cool, I'm glad this could be merged. Now, I do not expect much more PRs that will result in big merge conflicts in the next weeks/months. I'm going to rebase my existing other PRs soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasbishop nicholasbishop nicholasbishop approved these changes

@GabrielMajeri GabrielMajeri Awaiting requested review from GabrielMajeri

Assignees

@phip1611 phip1611

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discuss Crate Features
3 participants
@phip1611 @nicholasbishop @GabrielMajeri